Repository navigation
Remove the Jenkins macOS and Windows incremental pipelines - #5681
Merged
Merged
Conversation
full-build.yml already builds and runs CTest on GitHub-hosted macOS x64, macOS arm64 and Windows 2022 for every pull request, so the Jenkins openstudio-incremental-osx and openstudio-incremental-windows jobs duplicate it. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the removal of the macOS and Windows incremental Jenkins entry points.
No open issues 🎉
What changed in this PR
Removes the macOS and Windows incremental Jenkins pipeline entry points as part of migrating OpenStudio CI to GitHub Actions. Existing full-build.yml coverage supports retiring these duplicate Jenkins jobs and their agents.
Changes:
- Deletes the macOS and Windows Jenkinsfiles that invoke shared-library incremental builds.
- Leaves Ubuntu incremental and code-coverage Jenkins pipelines unchanged.
| File | Description |
|---|---|
Jenkinsfile_develop_windows |
Removes the Windows incremental pipeline entry point. |
Jenkinsfile_develop_osx |
Removes the macOS incremental pipeline entry point. |
Review effort: Balanced
added 2 commits
November 10, 2026 11:00
…ows EXE Jenkins osx/windows built PRs against every base branch and published the PR's Windows installer. With those jobs retired, drop the pull_request branch filter so release-freeze and feature-branch PRs keep macOS/Windows CI, and upload the unsigned cpack EXE on PRs (signing only runs on develop, master and tags). The artifact name stays outside windows-publish's download pattern so an unsigned EXE can never reach S3.
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of moving CI off Jenkins (ci.openstudio.net).
full-build.ymlalready runs on every PR to develop and builds and runs CTest on GitHub-hosted runners: macOS x64 (~143 min), macOS arm64 (~68 min) and Windows 2022 (~91 min), timed on PR #5678's run. That makes the Jenkinsopenstudio-incremental-osxandopenstudio-incremental-windowsjobs duplicates. Those jobs depend on the last Intel Mac mini and the EC2 Windows agent, both of which we want to retire.Results on recent PRs where both ran:
Once this merges, Jenkins drops those two jobs' branches, and the jobs themselves get deleted on ci.openstudio.net. The Ubuntu incremental and code-coverage Jenkinsfiles stay until their GitHub replacements are ready.
Covering what Jenkins did that Full Build didn't
PRs to any base branch. Jenkins built PRs against every target (release freezes,
bump_deps, feature branches). Full Build only triggered on develop, master and os-4.0-dev, so this drops thepull_requestbranch filter. PRs to other branches now run the full macOS/Windows/Linux build too.Windows installer on PRs. Signing only runs on develop, master and tags, so PRs had no Windows
.exeartifact. PRs now upload the unsigned cpack installer asOS-Unsigned-EXE-windows-2022-x64-<sha>, a name outsidewindows-publish's download pattern so it can't reach S3.Follow-up after merge. For
pull_requestevents GitHub reads the workflow from the PR's test merge commit, so a PR whose base and head both predate this change still won't trigger Full Build. Merge develop once into any long-lived branch that takes PRs (e.g. a revivedv25.2.0-IOFreeze). Branches cut from develop after this merges pick it up automatically.🤖 Generated with Claude Code